Merged
Conversation
Member
oschwald
commented
Mar 10, 2025
oschwald
commented
- Put main() before usage()
- Support glob for -db parameter
- Eliminate unnecessary any uses
- Run golines on code
- Don't export functions unnecessarily
- Switch to iterator for results
- Make the default output format YAML
- Improve network/IP parsing
- Do not have a public Go API
- Add a flag to include networks without data
- Do not escape for HTML again
- Add ability to output build time
Also rearrange them as appropriate.
Modver resultThis report was generated by Modver, This PR requires an increase in your module’s major version number. |
oschwald
force-pushed
the
greg/eng-1454-mmdbinspect-is-easier-to-use-for-historical-database
branch
from
e3c0a34 to
b71ea75
Compare
oschwald
force-pushed
the
greg/eng-1454-mmdbinspect-is-easier-to-use-for-historical-database
branch
3 times, most recently
from
a0b355f to
629a637
Compare
oschwald
force-pushed
the
greg/eng-1454-mmdbinspect-is-easier-to-use-for-historical-database
branch
from
629a637 to
9bf3c2b
Compare
blakeyjason
approved these changes
Mar 11, 2025
blakeyjason
deleted the
greg/eng-1454-mmdbinspect-is-easier-to-use-for-historical-database
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.